Add scrollviewers to settings UI#7998
Merged
DHowett merged 1 commit intofeature/settings-uifrom Oct 22, 2020
Merged
Conversation
DHowett
approved these changes
Oct 21, 2020
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
wow, it's rare that we get something "for free" with xaml.
zadjii-msft
approved these changes
Oct 21, 2020
leonMSFT
approved these changes
Oct 21, 2020
carlos-zamora
approved these changes
Oct 21, 2020
Member
|
it's got four signoffs somebody just merge it instead of signing off some more |
DHowett
approved these changes
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This fixes the bug where the reset/save footer covers settings.
References
#1564
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed