Replace ObjectModel references in SUI#7970
Merged
16 commits merged intofeature/settings-uifrom Oct 21, 2020
Merged
Conversation
DHowett
reviewed
Oct 19, 2020
DHowett
reviewed
Oct 19, 2020
DHowett
approved these changes
Oct 19, 2020
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
If what cz and I chatted about is correct -- carlos, back me up here! -- you can probably undo all the observability changes!
| // this section will clone the active AppSettings | ||
| _settingsSource = AppSettings(); | ||
| _settingsClone = _settingsSource.Clone(); | ||
| MainPage::_settingsSource = settings; |
Member
There was a problem hiding this comment.
be real careful with static things.
…soft/terminal into dev/lelian/sui-without-objectmodel
miniksa
reviewed
Oct 20, 2020
DHowett
approved these changes
Oct 21, 2020
carlos-zamora
approved these changes
Oct 21, 2020
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
This looks great! Thanks!
leonMSFT
added
the
AutoMerge
|
Hello @leonMSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR's main goal was to get rid of all our ObjectModel references and replace them with references to TSM.
There's a lot of places in the SUI where I wasn't able to easily drop in the TSM. Usually those settings types aren't as simple as a boolean, so they'll require some templating and finessing. For those settings, I've either commented them out for now or attempted to replace them. Here's a TLDR of what I've done in this PR.
MainPageis the entry point, it gets aCascadiaSettingsobject to hold on to, and that's the settings object the rest of the pages will bind to.ObjectModelalong with their references..xamlfiles with a reference to the settings object obtained inMainPageColorSchemes.xaml