Implement CascadiaSettings::Copy()#7877
Conversation
carlos-zamora
added
Area-Settings
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
It's a shame that this doesn't work well with a macro for auto-synthesizing these Copy methods. I highly expect either a merge conflict with this PR causing a property to not get copied, or for a future PR to forget to Copy a property
leonMSFT
left a comment
leonMSFT
left a comment
There was a problem hiding this comment.
Seems pretty straightforward, do you think you could make a small test to test out the whole SUI scenario of making a copy, making some changes, and then replacing the original? Then check that the settings you've changed are what you expect them to be in the original copy.
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
5 participants
Summary of the Pull Request
This implements the
Copyfunction forCascadiaSettings. Copy performs a deep copy of aCascadiaSettingsobject. This is needed for data binding in the Terminal Settings Editor.The
Copyfunction was basically implemented in every settings model object. This was mostly just repetitive work.References
#7667 - TSM
#1564 - Settings UI
PR Checklist