Keep degenerate UIA text ranges degenerate after movement#7530
Merged
7 commits merged intomicrosoft:masterfrom Sep 4, 2020
Merged
Keep degenerate UIA text ranges degenerate after movement#75307 commits merged intomicrosoft:masterfrom
7 commits merged intomicrosoft:masterfrom
Conversation
ghost
added
Area-Accessibility
codeofdusk
force-pushed
the
dev/codeofusk/i7342
branch
from
ebfd789 to
3eb15fc
Compare
carlos-zamora
requested changes
Sep 4, 2020
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
This test is failing:
Not too bad though. Just change this line to:
{4, 0+1}
Bonus points if you add a similar test to CanMoveByLine tests here:
ghost
added
the
Needs-Author-Feedback
Member
|
Forgot to say, other than that, it looks good! Thanks! |
Co-authored-by: Carlos Zamora <[email protected]>
ghost
removed
the
Needs-Author-Feedback
carlos-zamora
requested changes
Sep 4, 2020
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
We're close 😊
Also, we have a code formatter. To run it, do this in your terminal:
# in pwsh, go to the repo's directory
Import-Module .\tools\OpenConsole.psm1
Invoke-CodeFormat
src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp
Outdated
Show resolved
Hide resolved
src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp
Outdated
Show resolved
Hide resolved
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
carlos-zamora
requested changes
Sep 4, 2020
src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp
Outdated
Show resolved
Hide resolved
ghost
added
the
Needs-Author-Feedback
…ts.cpp Co-authored-by: Carlos Zamora <[email protected]>
ghost
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Sep 4, 2020
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
This is excellent, and a very good catch. Thank you 😄L
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
@carlos-zamora double-tap plz |
carlos-zamora
approved these changes
Sep 4, 2020
ghost
merged commit 
Contributor
Author
|
Any rough timeline for when this will make it to insider inbox? |
Member
|
This is merging to Windows today; it will be a couple weeks before it goes out to Insiders. 😄 Thanks again for the contribution. I'll let you know when it's out. |
DHowett
pushed a commit
that referenced
this pull request
Sep 18, 2020
Conhost expands UIA text ranges when moved. This means that degenerate ranges become non-degenerate after movement, leading to odd behaviour from UIA clients. This PR doesn't expand degenerate ranges, but rather keeps them degenerate by moving `_end` to the newly-changed `_start`. Tested in the NVDA Python console (cases with `setEndPoint` and `compareEndPoints` described in #7342). Also ran the logic by @michaelDCurran. Closes #7342 Almost definitely addresses nvaccess/nvda#11288 (although I'll need to test with my Braille display). Also fixes an issue privately reported to me by @Simon818 with copy/paste from review cursor which originally lead me to believe the issue was with `moveEndPointByRange`. (cherry picked from commit 7a03f75)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conhost expands UIA text ranges when moved. This means that degenerate
ranges become non-degenerate after movement, leading to odd behaviour
from UIA clients. This PR doesn't expand degenerate ranges, but rather
keeps them degenerate by moving
_endto the newly-changed_start.Tested in the NVDA Python console (cases with
setEndPointandcompareEndPointsdescribed in #7342). Also ran the logic by@michaelDCurran.
Closes #7342 and nvaccess/nvda#11288
Also fixes an issue privately reported to
me by @Simon818 with copy/paste from review cursor which originally lead
me to believe the issue was with
moveEndPointByRange.