Open up content dialogs for invalid URIs and unsupported schemes#7523
Open up content dialogs for invalid URIs and unsupported schemes#7523
Conversation
| x:Name="UnsupportedSchemeDialog" | ||
| x:Uid="UnsupportedSchemeDialog" | ||
| DefaultButton="Primary"> |
There was a problem hiding this comment.
should the unsupported scheme dialog have an "Open Anyway" button that will allow the user an escape hatch?
There was a problem hiding this comment.
I have to say that makes me quite nervous - I am not sure what ShellExecute can do with other schemes and we do not have anything in place yet to check for safety of the link
There was a problem hiding this comment.
You could show the full link in the dialog box though and allow the user to copy it, so they can get the data. There could even be a button called "Copy link to clipboard".
There was a problem hiding this comment.
I agree that there should be some way of letting the user take the URI out if we're not going to handle it ourselves for whatever reason.
There was a problem hiding this comment.
The user can copy the URI from the dialog box that pops out! (The text is selectable)
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
ghost
requested review from
carlos-zamora,
leonMSFT,
miniksa and
zadjii-msft
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
I'm fine with this, but I don't want to sign until we find some way for the user to get the content out if they're really desperate to run that link by some other means.
|
🎉 Handy links: |
6 participants
Summary of the Pull Request
If a user clicks a link that is either invalid (cannot be parsed) or has a scheme we do not support (like file or mailto (for now)), we open up a dialog box telling them the issue.
References
#5001
PR Checklist
Detailed Description of the Pull Request / Additional comments