Make index in closeOtherTabs and closeTabsAfter optional#7390
Merged
2 commits merged intomasterfrom Aug 25, 2020
Merged
Conversation
ghost
added
Area-UserInterface
zadjii-msft
approved these changes
Aug 25, 2020
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Meh, these are nits. I'd love to hear other people's thoughts
miniksa
reviewed
Aug 25, 2020
miniksa
reviewed
Aug 25, 2020
miniksa
requested changes
Aug 25, 2020
Member
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
Looks fine. Req changes due to the handled true/false discussion.
ghost
added
the
Needs-Author-Feedback
Member
|
This is not specific to your PR, but we need to make sure that "after" works properly when the UI is in RTL layout . . . if that still exists |
ghost
removed
the
Needs-Author-Feedback
miniksa
approved these changes
Aug 25, 2020
DHowett
approved these changes
Aug 25, 2020
Member
|
@msftbot merge this in 1 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Aug 25, 2020
## Summary of the Pull Request The `index` action argument is now optional for `closeOtherTabs` and `closeTabsAfter`. When `index` is not defined, `index` is set to the focused tab's index. Also, adds the non-index version of these actions to defaults.json. ## PR Checklist * [X] Closes #7181 * [X] CLA signed * [X] Tests passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [X] Schema updated. ## Validation Steps Performed Opened 4 tabs and ran closeOtherTabs/closeTabsAfter from command palette. (cherry picked from commit 2fdc88f)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The
indexaction argument is now optional forcloseOtherTabsandcloseTabsAfter. Whenindexis not defined,indexis set to the focused tab's index.Also, adds the non-index version of these actions to defaults.json.
PR Checklist
indexparam ofcloseOtherTabs,closeTabsAftershould be optional #7181Validation Steps Performed
Opened 4 tabs and ran closeOtherTabs/closeTabsAfter from command palette.