Add a Settings UI Prototype by carlos-zamora · Pull Request #7370 · microsoft/terminal

carlos-zamora · 2020-08-22T00:00:21Z

This commit introduces a rough prototype of the Settings UI as the
TerminalSettingsEditor. This project was added to OpenConsole.sln and
deploys as a standalone app. Some databinding is configured to a fake
TerminalSettingsModel (located in the ObjectModel folder).

This commit will start the settings UI feature branch, which will
receive a full review on merge-back into main.

References #6720 - Settings UI Spec and Design
References #1564 - Settings UI Feature/Epic

Match nav panel icons

Almedina ms/nav panel

ObjectModel stays in TerminalSettings though because that's how things will work out in the _real_ object model.

Cleanup of the settings UI.

Add launch page

Add interaction page

carlos-zamora · 2020-08-25T23:35:31Z

Could I get a bit of guidance for how to handle these misspellings? Most seem to be function names.

zadjii-msft · 2020-08-26T00:13:11Z

without looking at any code of course

addnew - looks like a real typo
bright* - I'd make these camelCase if possible, that'll fix the bot
delimeters - looks like a real typo
globalprofile - can you camelCase this?
homegriditem - can you camelCase this?
muxc - microsoft.txt
snprintf - apis.txt
Subheader - can you camelCase this?
Subpage - can you camelCase this?
tolower - apis.txt
viceversa - "vice-versa"
wcsstr - apis.txt

DHowett · 2020-08-28T00:31:17Z

/azp run

azure-pipelines · 2020-08-28T00:31:34Z

Azure Pipelines successfully started running 1 pipeline(s).

src/cascadia/TerminalSettingsEditor/ObjectModel/GlobalSettings.idl

DHowett

Rationale

This is merging into a feature branch that Leon and Carlos are going to be hammering on for a while. It is a prototype, yes, but it is getting refined.

There will be a final review when the feature branch merges.

src/cascadia/TerminalSettingsEditor/AddProfile.xaml

src/cascadia/TerminalSettingsEditor/App.cpp

src/cascadia/TerminalSettingsEditor/App.h

src/cascadia/TerminalSettingsEditor/App.idl

src/cascadia/TerminalSettingsEditor/App.xaml

src/cascadia/TerminalSettingsEditor/Package.appxmanifest

src/cascadia/TerminalSettingsEditor/Profiles.cpp

src/cascadia/TerminalSettingsEditor/Profiles.xaml

src/cascadia/TerminalSettingsEditor/PropertySheet.props

src/cascadia/TerminalSettingsEditor/Utils.cpp

leonMSFT

TBH I think a lot of the things I saw are stuff that's going to be deleted and polished naturally as we work towards endgame. i.e. large amounts of repeating XAML elements just becomes a templated item + data binding.

Blocking for now just so we can sprinkle TODOs throughout the code first before merging this in.

src/cascadia/TerminalSettingsEditor/AddProfile.xaml

src/cascadia/TerminalSettingsEditor/Keybindings.cpp

src/cascadia/TerminalSettingsEditor/Launch.xaml

leonMSFT

For the Leon callouts - those changes are currently already in the branch that I'm currently working on to put the settings UI in a tab, so they'll come in a later PR.

I've also put the Epic callouts in a follow up list in #1564. I expect we'll be referring back to that list often as we work thoroughly in the code.

as discussed

ghost · 2020-09-17T18:33:22Z

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

This commit introduces a rough prototype of the Settings UI as the `TerminalSettingsEditor`. This project was added to OpenConsole.sln and deploys as a standalone app. Some databinding is configured to a fake TerminalSettingsModel (located in the ObjectModel folder). This commit will start the settings UI feature branch, which will receive a full review on merge-back into main. References #6720 - Settings UI Spec and Design References #1564 - Settings UI Feature/Epic

cinnamon-msft and others added 30 commits July 23, 2020 08:25

add settings ui prototype

e07667a

fix packages filepaths

9e40d01

Add panel list items to match mockups

bb07e3c

add rudimentary object model

5e45058

Merge pull request #1 from cinnamon-msft/almedina-ms/NavPanel

4f888db

Match nav panel icons

Replicate sub menus

d6d835c

Fix submenus

d22616c

Remove extra line

fe1261b

move objects to new folder; initialize XAML with settings object

ad723f7

Rename VS Project to SettingsControl

0160cdc

~polish~

f053823

Update Top-Level Navigation Items

69f2b54

Almedina ms/nav panel

merge master

e7c0a8c

Add rudimentary object model

e3d1906

merge master

c59bfcf

keep ObjectModel in TerminalSettings though

b462e91

Rename VS Project to SettingsControl

bb61353

ObjectModel stays in TerminalSettings though because that's how things will work out in the _real_ object model.

Tweaking the UI to be closer to the mockups

3c5fc97

Merge pull request #5 from cinnamon-msft/vithoma/ObjectBinding_General

6229da3

Cleanup of the settings UI.

fix carlos

e5970a5

Kayla broke the build

af572e2

Profiles page almost done

48fad75

Added more UI changes

ac9174f

cleanup

75da7e1

add launch page

b435b53

Add launch page

2864818

Add launch page

add interaction page

b97af15

Merge pull request #10 from cinnamon-msft/cinnamon/general-xaml

932ceda

Add interaction page

add rendering page

49b0080

add appearance - global page

53b3b16

address spell checker and CI failure

3a599ef

quangkieu mentioned this pull request Aug 27, 2020

Add initial settings UI spec #6720

Merged

6 tasks

DHowett changed the base branch from master to feature/settings-ui August 28, 2020 00:30

fix CI

351e1af

cinnamon-msft mentioned this pull request Sep 4, 2020

Feature Request - Implement Settings UI #1564

Closed

34 tasks

carlos-zamora assigned miniksa Sep 9, 2020

miniksa reviewed Sep 9, 2020

View reviewed changes

src/cascadia/TerminalSettingsEditor/ObjectModel/GlobalSettings.idl Show resolved Hide resolved

remove TODO CARLOS

c14dea3

DHowett approved these changes Sep 11, 2020

View reviewed changes

leonMSFT suggested changes Sep 11, 2020

View reviewed changes

src/cascadia/TerminalSettingsEditor/AddProfile.xaml Show resolved Hide resolved

src/cascadia/TerminalSettingsEditor/Keybindings.cpp Show resolved Hide resolved

src/cascadia/TerminalSettingsEditor/Launch.xaml Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 11, 2020

leonMSFT added 3 commits September 14, 2020 14:37

TODOs, cleanups, namespaces

f214ebc

formatting

b2e3da9

ok fine i'll separate the word in two

07d1480

leonMSFT approved these changes Sep 14, 2020

View reviewed changes

carlos-zamora unassigned miniksa Sep 14, 2020

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 14, 2020

Merge branch 'feature/settings-ui' into dev/cazamor/settings-ui

3f4b2d2

DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 17, 2020

ghost merged commit 9493ca0 into feature/settings-ui Sep 17, 2020

ghost deleted the dev/cazamor/settings-ui branch September 17, 2020 18:33

carlos-zamora mentioned this pull request Oct 7, 2020

Add settings UI string localization #7833

Merged

6 tasks

carlos-zamora mentioned this pull request Dec 11, 2020

Epic: Settings UI Completion #6800

Open

25 tasks

This pull request was closed.

Conversation

carlos-zamora commented Aug 22, 2020 • edited by DHowett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlos-zamora commented Aug 25, 2020

Uh oh!

zadjii-msft commented Aug 26, 2020

Uh oh!

DHowett commented Aug 28, 2020

Uh oh!

azure-pipelines bot commented Aug 28, 2020

Uh oh!

Uh oh!

DHowett left a comment

Choose a reason for hiding this comment

Rationale

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leonMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leonMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Sep 17, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

carlos-zamora commented Aug 22, 2020 •

edited by DHowett

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.