fix tab control and tabs is not synced after focused tab is removed#737
Merged
zadjii-msft merged 2 commits intomicrosoft:masterfrom May 14, 2019
bef178:tab-sync
Merged
fix tab control and tabs is not synced after focused tab is removed#737zadjii-msft merged 2 commits intomicrosoft:masterfrom bef178:tab-sync
zadjii-msft merged 2 commits intomicrosoft:masterfrom
bef178:tab-sync
Conversation
zadjii-msft
approved these changes
May 13, 2019
Member
|
@bef178 Could you make the title more descriptive? "Tab Sync" will be really hard to remember what it means when looking back at the commit log 3 months from now. |
zadjii-msft
added
the
Issue-Bug
miniksa
approved these changes
May 13, 2019
Member
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
I approve, conditional on fixing the things @zadjii-msft already commented on. I have the same concerns.
bef178
changed the title
bef178
changed the title
bef178
changed the title
This was referenced May 15, 2019
ObsidianPhoenix
pushed a commit
to ObsidianPhoenix/Terminal
that referenced
this pull request
May 15, 2019
…icrosoft#737) * trim duplicated github627 * fix tab control and tabs is not synced after focused tab is removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #708