Compensate for new warnings and STL changes in VS 16.7#7319
Conversation
miniksa
added
Product-Conhost
|
Wait a minute they are allowed to do that? I thought noexcept was only a nightmare in users’ code. Isn’t there some kind of regulation to prevent the signatures of std functions from changing? |
|
I believe that removing noexcept is considered a breaking change, but adding it may not be? |
|
@msftbot merge this in like 5 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
I swear I'm not crazy. On my machine (with 16.7.1) it says that
|
|
My machine is using this path for STL: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include Which would mean the build machine is on Visual Studio 16.6.5. |
|
I'll yank the noexcept from erase until the build machines rev to 16.7. But I have no idea why them going to (apparently) 16.6.5 this weekend broke all the other stuff. Basically what I'm saying is... GUH. |
ghost
merged commit New warnings were added in VS 16.7 and `std::map::erase` is now `noexcept`. Update our code to be compatible with the new enforcement. ## PR Checklist * [x] Closes broken audit in main after Agents updated over the weekend. * [x] I work here. * [x] Audit mode passes now * [x] Am core contributor. ## Validation Steps Performed * [x] Ran audit mode locally (cherry picked from commit a50c48c)
This is just the `noexcept` part of #7319, because the CI apparently got updated overnight.
Dustin L. Howett * Clear the last error before calling Mb2Wc in ConvertToW (GH-7391) * Update clang-format to 10.0 (GH-7389) * Add til::static_map, a constexpr key-value store (GH-7323) James Holderness * Refactor VT control sequence identification (CC-7304) Mike Griese * Compensate for VS 16.7, part 2 (GH-7383) * Add support for iterable, nested commands (GH-6856) Michael Niksa * Helix Testing (GH-6992) * Compensate for new warnings and STL changes in VS 16.7 (GH-7319) nathpete-msft * Fix environment block creation (GH-7401) Chester Liu * Add initial support for VT DCS sequences (CC-6328) Related work items: #28791050
4 participants
New warnings were added in VS 16.7 and
std::map::eraseis nownoexcept.Update our code to be compatible with the new enforcement.
PR Checklist
Validation Steps Performed