Skip to content

Don't zoom when there's only one pane#7273

Merged
1 commit merged intomasterfrom
dev/migrie/b/sometimes-dont-zoom
Aug 13, 2020
Merged

Don't zoom when there's only one pane#7273
1 commit merged intomasterfrom
dev/migrie/b/sometimes-dont-zoom

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Aug 13, 2020

This is a minor fix from #6989. If there's only one pane in the
Terminal, then we'd still "zoom" it and give it a border, but all the
borders would be black.

A single pane is already "zoomed", so it doesn't really make sense to
try and zoom if there's only one.

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Aug 13, 2020
@DHowett
Copy link
Member

DHowett commented Aug 13, 2020

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 13, 2020
@ghost
Copy link

ghost commented Aug 13, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 13 Aug 2020 19:17:08 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 01e3fda into master Aug 13, 2020
@ghost ghost deleted the dev/migrie/b/sometimes-dont-zoom branch August 13, 2020 19:18
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants