Enable partial rebuilds of the TerminalControl project again#7248
Merged
Enable partial rebuilds of the TerminalControl project again#7248
Conversation
…gain, something that recently regressed
Member
Author
|
@msftbot make sure @DHowett signs off on this |
ghost
added
the
AutoMerge
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
zadjii-msft
added
Area-Build
DHowett
reviewed
Aug 11, 2020
| <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion> | ||
| <RootNamespace>Microsoft.Terminal.TerminalControl</RootNamespace> | ||
|
|
||
| <!-- sets a bunch of Windows Universal properties --> |
Member
There was a problem hiding this comment.
would that we explained why we needed this! i hate that it's a magic giant hammer that fixes weird problems.
DHowett
approved these changes
Aug 11, 2020
carlos-zamora
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regressed around the #7163 timeframe.
We're discussing this on chat currently. It might break the intellisense
on the
#include <winrt/Microsoft.Terminal.TerminalControl.h>line inVS 16.7, but we're not really sure? Intellisense has been notoriously
flaky for us.
I'm running 16.6.5, and it works for me. @lhecker is running 16.7 and
confirmed it worked there. If the CI build passes, then this definitely
will work for 16.7.