Add support for the "crossed-out" graphic rendition attribute#7143
Add support for the "crossed-out" graphic rendition attribute#71432 commits merged intomicrosoft:masterfrom
Conversation
ghost
added
Area-Rendering
|
Note that I've marked this as closing #6205, although there is actually a second test case in that issue that isn't covered by this PR - using a combining long stroke Unicode character to achieve a strikethrough effect. That seems like it should be a completely separate issue, though, and wasn't something that the OP was particularly concerned about anyway. |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 17 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
3 participants
This PR adds support for the ANSI crossed-out graphic rendition
attribute, which is enabled by the
SGR 9escape sequence.originally added in Add support for passing through extended text attributes, like… #2917.
was added in Refactor grid line renderers with support for more line types #7107.
Since the majority of the code required for this attribute had already
been implemented, it was just a matter of activating the
GridLines::Strikethroughstyle in theRenderer::s_GetGridlinesmethod when the
CrossedOutattribute was set.VALIDATION
There were already some unit tests in place in
VtRendererTestand theScreenBufferTests, but I've also now extended the SGR tests inAdapterTestto cover this attribute.I've manually confirmed the first test case from #6205 now works as
expected in both conhost and Terminal.
Closes #6205