Added requestedTheme option into terminal settings#710
Conversation
|
|
|
The most common scenarios should be there in the GUI, with a button in the settings screen to open the commented JSON file with advanced settings |
|
This change just exposes that setting in the default |
Gusted
left a comment
Gusted
left a comment
There was a problem hiding this comment.
Good thinking to add this as an option!
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
I have a tiny nit pick newline comment, but I also want an answer to @DHowett-MSFT's question before I sign.
|
@DHowett-MSFT yes, this change just exposes the setting to change the theme in the json file. |
|
|
||
| _globals.SetDefaultProfile(powershellProfile.GetGuid()); | ||
|
|
||
| _globals.SetRequestedTheme(winrt::Windows::UI::Xaml::ElementTheme::Default); |
There was a problem hiding this comment.
CreateDefaultProfiles isn't a great place for this .. is there something more generic or less default-profile-related to put it?
ghost
added
the
Needs-Author-Feedback
|
That makes sense. Thanks! |
ghost
removed
the
Needs-Author-Feedback
|
I found what was blocking the serialization of the requestedTheme value in the json file. Now it works. |
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
Co-Authored-By: Dustin L. Howett (MSFT) <[email protected]>
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here. |
DHowett-MSFT
dismissed
miniksa’s stale review
As far as I can tell, Michael's only blocker was getting an answer to my question. As it's been answered satisfactorily, I'm clearing his block.
ghost
merged commit 8 participants
Added the possibility to change the theme (dark/light/default) from the terminal settings