Spec for global action IDs#6902
Closed
zadjii-msft wants to merge 5 commits intodev/migrie/s/#1571-new-tab-menufrom
Closed
Spec for global action IDs#6902zadjii-msft wants to merge 5 commits intodev/migrie/s/#1571-new-tab-menufrom
zadjii-msft wants to merge 5 commits intodev/migrie/s/#1571-new-tab-menufrom
Conversation
Comment on lines
+106
to
+126
| ```json | ||
| { | ||
| "newTabMenu": [ | ||
| { "type":"action", "id": "Terminal.IncreaseFontSize" }, | ||
| { "type":"action", "id": "Terminal.DecreaseFontSize" }, | ||
| { "type":"action", "id": "Terminal.ResetFontSize" }, | ||
| { "type":"profile", "profile": "cmd" }, | ||
| { "type":"profile", "profile": "Windows PowerShell" }, | ||
| { "type":"separator" }, | ||
| { | ||
| "type":"folder", | ||
| "name": "Settings...", | ||
| "icon": "C:\\path\\to\\icon.png", | ||
| "entries":[ | ||
| { "type":"action", "id": "Terminal.OpenDefaultSettings" }, | ||
| { "type":"action", "id": "Terminal.OpenSettings" }, | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ``` |
Member
There was a problem hiding this comment.
Yes! I love this. It looks a lot cleaner.
Member
|
This PR is unreviewable for me because it looks like this branch merged master but new-tab-menu didn't |
Member
Author
|
@DHowett whoops, didn't push my local updates to |
Member
|
double-retargeted the branch, now it looks 💯 |
zadjii-msft
added
Area-Settings
3 tasks
zadjii-msft
changed the base branch from
dev/migrie/s/#1571-new-tab-menu
to
master
zadjii-msft
changed the base branch from
master
to
dev/migrie/s/#1571-new-tab-menu
Member
Author
|
Moved to #7175 |
zadjii-msft
added a commit
that referenced
this pull request
Aug 12, 2020
## Summary of the Pull Request⚠️ This spec has been moved from #6902. That version was branched off the new tab menu customization, and had a terribly convoluted git history. After discussion with the team, we've decided that it's best that this spec is merged atomically _first_, and used as the basis for #5888, as opposed to the other way around. > This document is intended to serve as an addition to the [Command Palette Spec], > as well as the [New Tab Menu Customization Spec]. > > As we come to rely more on actions being a mechanism by which the user defines > "do something in the Terminal", we'll want to make it even easier for users to > re-use the actions that they've already defined, as to reduce duplicated json as > much as possible. This spec proposes a mechanism by which actions could be > uniquely identifiable, so that the user could refer to bindings in other > contexts without needing to replicate an entire json blob. > ## PR Checklist * [x] Specs: #6899 * [x] References: #1571, #1912, #3337, #5025, #5524, #5633 * [x] I work here ## Detailed Description of the Pull Request / Additional comments _\*<sup>\*</sup><sub>\*</sub> read the spec <sub>\*</sub><sup>\*</sup>\*_ [Command Palette Spec]: https://github.com/microsoft/terminal/blob/master/doc/specs/%232046%20-%20Command%20Palette.md [New Tab Menu Customization Spec]: https://github.com/microsoft/terminal/blob/master/doc/specs/%231571%20-%20New%20Tab%20Menu%20Customization.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
*** read the spec ***