Skip to content

Update MUX to 2.5.0-prerelease.200609001#6819

Merged
1 commit merged intomasterfrom
dev/migrie/f/mux-2.5
Jul 7, 2020
Merged

Update MUX to 2.5.0-prerelease.200609001#6819
1 commit merged intomasterfrom
dev/migrie/f/mux-2.5

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Jul 7, 2020 •
edited by DHowett
Loading

See: https://github.com/microsoft/microsoft-ui-xaml/releases/tag/v2.5.0-prerelease.200609001

Notable Changes:

Resize tab view items only once the pointer has left the TabViewItem strip (microsoft/microsoft-ui-xaml#2569)
Align TabView visuals with Edge (microsoft/microsoft-ui-xaml#2201)
Fix background of MenuFlyout in white high contrast (microsoft/microsoft-ui-xaml#2446)
TabView: Make TabViewItem consume the TabViewItemHeaderForeground theme resource (microsoft/microsoft-ui-xaml#2348)
TabView: Add tooltips to its scrolling buttons. (microsoft/microsoft-ui-xaml#2369)

@ghost ghost added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 7, 2020
@jtippet jtippet mentioned this pull request Jul 7, 2020
Closed
@jtippet
Copy link
Contributor

jtippet commented Jul 7, 2020

Closes #5360? @jtippet can correct me if I'm wrong about this.

It takes us one step further. But personally I am not ready to declare success on 5360 until Terminal is using ApplicationHighContrastAdjustment::None. That's what will really activate all the bits and pieces that we've been lining up.

@DHowett DHowett added the Needs-Second It's a PR that needs another sign-off label Jul 7, 2020
@ghost ghost requested review from carlos-zamora, leonMSFT and miniksa July 7, 2020 20:54
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 7, 2020
@ghost
Copy link

ghost commented Jul 7, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit edd8ac8 into master Jul 7, 2020
@ghost ghost deleted the dev/migrie/f/mux-2.5 branch July 7, 2020 23:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees

No one assigned

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zadjii-msft @jtippet @DHowett @carlos-zamora