Add a ShortcutAction for toggling retro terminal effect#6691
Merged
2 commits merged intomasterfrom Jul 1, 2020
Merged
Conversation
zadjii-msft
added
Area-TerminalControl
carlos-zamora
approved these changes
Jun 26, 2020
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
As a tangential idea, if we're going to be making more and more "toggle<setting>" commands, should we just introduce a setSetting command? We could design it to take in multiple values for a setting, and each invocation just cycles through those values.
NOTE: this idea doesn't block this PR because we could just have 2 ways to toggle the retro terminal effect
Member
|
Merge pushed. This won't have a name for now but that's okay. |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
approved these changes
Jul 1, 2020
ghost
merged commit 
3 tasks
ghost
pushed a commit
that referenced
this pull request
Jul 7, 2020
…6806) ## Summary of the Pull Request In the wake of #6635, a couple things got missed in merges: * `toggleRetroEffect` didn't get into the schema, nor did `renameTab` or `commandPalette`. * `toggleRetroEffect` also didn't get a name Furthermore, I thought it might be a good idea to start sticking commands into `bindings` even without `keys`. So I tried doing that for `opentabColorPicker` and `toggleRetroEffect`, and found immediately that the labels for the key chord still appear even when the text is empty. So I added some XAML magic to hide those when the text is empty. ## References * #6762 * #6691 * #6557 * #6635 ## PR Checklist * [x] Closes #6762 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments * See also: https://docs.microsoft.com/en-us/windows/uwp/data-binding/data-binding-quickstart#formatting-or-converting-data-values-for-display - make sure to switch to C++/WinRT at the top! ## Validation Steps Performed Removed all my manual actions, ran the Terminal: 
|
🎉 Handy links: |
1 task
ghost
added
Area-Settings
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty straightforward.
toggleRetroEffectwill work to toggle theretro terminal effect on/off.
EDIT: