Skip to content

Recycle assorted rendering components to accelerate drawing #6483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
15 commits merged into from
Jun 22, 2020
Merged

Recycle assorted rendering components to accelerate drawing #6483

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9ad9b01
Recycle CustomTextLayouts between layout/render actions. This saves a…
miniksa Jun 12, 2020
942e7d5
order runs inplace with std::sort to dump the overhead of vector allo…
miniksa Jun 12, 2020
bcb1ecd
be fussy about our &s.
miniksa Jun 12, 2020
7d0af68
code formatter.
miniksa Jun 12, 2020
bff43ae
consolidate push/pop clip calls to be per-row.
miniksa Jun 12, 2020
2f44fb9
eliminate cursor turds.
miniksa Jun 15, 2020
6b34284
A little cleanup and static analysis fixes.
miniksa Jun 15, 2020
65c2d93
dump explicit frame info, just stash the cursor info where we need it.
miniksa Jun 15, 2020
1ab1dec
Change DrawingContext constructor to initializer list pattern.
miniksa Jun 17, 2020
8bd876b
use optional instead of item and bool to ensure we don't end up in a …
miniksa Jun 17, 2020
d24986f
move grayscale aa calculation to helper, use it in brush updates to e…
miniksa Jun 17, 2020
5f0adb7
missed a spot with the optional.
miniksa Jun 17, 2020
747db58
code format DID bark.
miniksa Jun 17, 2020
74328f9
Fix selection issue. Selection needs to dump the clip if it's leftove…
miniksa Jun 19, 2020
b9c781f
Merge branch 'master' into dev/miniksa/recycle
miniksa Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
eliminate cursor turds.
  • Loading branch information
@miniksa
miniksa committed Jun 15, 2020
commit 2f44fb97dc41c388591132174bc90915d148f827
4 changes: 4 additions & 0 deletions src/renderer/dx/DxRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,7 @@ CATCH_RETURN()
try
{
_sizeTarget = Pixels;

_invalidMap.resize(_sizeTarget / _glyphCell, true);
return S_OK;
}
Expand Down Expand Up @@ -1345,6 +1346,9 @@ try
RETURN_IF_FAILED(_customLayout->Reset());
RETURN_IF_FAILED(_customLayout->AppendClusters(clusters));

// Copy cursor info into drawing context
Comment thread
miniksa marked this conversation as resolved.
Outdated
_drawingContext->cursorInfo = _frameInfo.cursorInfo;

// Layout then render the text
RETURN_IF_FAILED(_customLayout->Draw(_drawingContext.get(), _customRenderer.Get(), origin.x, origin.y));

Expand Down