Summary of the Pull Request

For a radio button group to work properly, they need sequential IDs. This moves the cursor radio buttons on the conhost property sheet to be sequential.

References

• Introduced with Prevent "Options" propsheet from reverting cursor shape settings #2663
• Found while investigating Discard old duplicates needs to be case-sensitive #4186

PR Checklist

• Closes unfiled issue found while investigating Discard old duplicates needs to be case-sensitive #4186
• I work here.
• Manual test.
• No documentation required.
• Am core contributor.

Detailed Description of the Pull Request / Additional comments

• CheckRadioButton takes a contiguous group of IDs. It will set one item in the list and then uncheck the rest. When a new one was added to the group, it was added to the end of the segment in the IDs file, but not immediately after the existing radio buttons. This means it accidentally turned off all the other buttons in the middle.
• To resolve this, I moved all the cursor buttons into their own sequential group number and I deprecated the old values.

Validation Steps Performed

• Ensured that the "Discard Old Duplicates" value was set in the registry, walked through debugger as conhost packed the TRUE value into the property sheet blob, walked through the property sheet console.dll as it unpacked the TRUE, then observed that the checkbox was actually set instead of getting unset by the CheckRadioButton call that went from 107 to 119 and accidentally unchecked number 112, IDD_HISTORY_NODUP even though I swear it was just set.