Add copyFormatting keybinding arg and array support#6004
Merged
Conversation
zadjii-msft
requested changes
Jun 10, 2020
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Member
|
shh bot, chill |
Member
Author
|
Urgh. Thanks. I'll get to this one today. |
48c7b0d to
f2bfeda
Compare
Member
Author
|
@DHowett Latest commit tries to use the new Json Utils but I had some trouble. No longer builds. Could I get some help? |
DHowett
reviewed
Jul 10, 2020
DHowett
reviewed
Aug 11, 2020
Member
DHowett
left a comment
There was a problem hiding this comment.
only nits remaining are on the string formatting! well done
DHowett
reviewed
Aug 11, 2020
DHowett
reviewed
Aug 11, 2020
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DHowett
reviewed
Aug 12, 2020
Member
Author
DHowett
approved these changes
Aug 15, 2020
14 tasks
|
🎉 Handy links: |
This was referenced Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of the Pull Request
Adds array support for the existing
copyFormattingglobal setting. This allows users to define which formats they would specifically like to be copied. A boolean value is still accepted and is translated to the following:false-->"none"or[]true-->"all"or["html", "rtf"]This also adds
copyFormattingas a keybinding arg forcopy. As with the global setting, a boolean value and array value is accepted.References
#5212 - Spec for formatted copying
#2690 - disable html copy
PR Checklist
Detailed Description of the Pull Request / Additional comments
CopyFormat is a winrt enum where each accepted format is a flag. Currently accepted formats include
html, andrtf. A boolean value is accepted and converted.trueis a conjunction of all the formats.falseonly includes plain text.For the global setting,
nullis not accepted. We already have a default value from before so no worries there.For the keybinding arg,
null(the default value) means that we just do what the global arg says to do. Overall, thecopyFormattingkeybinding arg is an override of the global setting when using that keybinding.Validation Steps Performed
Validated behavior with every combination of values below:
copyFormattingglobal: {true,false,[],["html"]}copyFormattingcopy arg: {null,true,false,[],[, "html"]}