Get rid of the padding above the tab row when maximized#5881
Merged
3 commits merged intomasterfrom May 21, 2020
Merged
Conversation
I thought this would be easier. I'm trying to do this the XAML-y way, so I get better at it. I'm annoyed that both ContentPresenter and Grid aren't `Control`s, because I thought this would work. I'm gonna really blow this file up, so I'm stashing this.
… resource so we'll just do it by hand
ghost
added
Area-UserInterface
carlos-zamora
approved these changes
May 13, 2020
ghost
requested review from
This was referenced May 21, 2020
DHowett
approved these changes
May 21, 2020
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
I hate using VSM, so... i dunno, this can probably be done better, but it probably can't be done more effectively than "literally exists today"
DHowett
reviewed
May 21, 2020
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
## Summary of the Pull Request When we maximize the window, shrink the caption buttons (the min, max, close buttons) down to 32px tall, to be the same height as the `TabRowControl`. This way, the tabs will be flush with the top of the display. ## PR Checklist * [x] Closes microsoft#2541 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments I tried for a couple hours this morning to do this as a `VisualState`. First I tried doing it as one on the TabRow, which I had very little success with. Then, I eventually realized that the TabRow wasn't even responsible for the padding there, it was being created by the fact that the caption buttons were too tall. Again, I tried to use the existing `VisualState`s they have defined for this, but I couldn't figure out how to do that. I think the visual state solution would be _cleaner_, so if someone knows how to do that instead, please let me know. ## Validation Steps Performed * Maximized/restored the Terminal on my display with the taskbar on the bottom * Maximized/restored the Terminal on my display with the taskbar on the top
|
🎉 Handy links: |
ghost
mentioned this pull request
5 tasks
DHowett
pushed a commit
that referenced
this pull request
Jun 24, 2020
## Summary of the Pull Request When we maximize the window, shrink the caption buttons (the min, max, close buttons) down to 32px tall, to be the same height as the `TabRowControl`. This way, the tabs will be flush with the top of the display. ## PR Checklist * [x] Closes #2541 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments I tried for a couple hours this morning to do this as a `VisualState`. First I tried doing it as one on the TabRow, which I had very little success with. Then, I eventually realized that the TabRow wasn't even responsible for the padding there, it was being created by the fact that the caption buttons were too tall. Again, I tried to use the existing `VisualState`s they have defined for this, but I couldn't figure out how to do that. I think the visual state solution would be _cleaner_, so if someone knows how to do that instead, please let me know. ## Validation Steps Performed * Maximized/restored the Terminal on my display with the taskbar on the bottom * Maximized/restored the Terminal on my display with the taskbar on the top (cherry picked from commit c373ebc)
|
🎉 Handy links: |
6 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When we maximize the window, shrink the caption buttons (the min, max, close buttons) down to 32px tall, to be the same height as the
TabRowControl. This way, the tabs will be flush with the top of the display.PR Checklist
Detailed Description of the Pull Request / Additional comments
I tried for a couple hours this morning to do this as a
VisualState. First I tried doing it as one on the TabRow, which I had very little success with. Then, I eventually realized that the TabRow wasn't even responsible for the padding there, it was being created by the fact that the caption buttons were too tall. Again, I tried to use the existingVisualStates they have defined for this, but I couldn't figure out how to do that.I think the visual state solution would be cleaner, so if someone knows how to do that instead, please let me know.
Validation Steps Performed