Conversation
ghost
added
Area-Server
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
I'm cool with this. Thank you for doing all the heavy lifting and digging through WGL4/CP437.
@j4james Does this seem like a reasonable set of glyphs for revert? Within the constraints of "some people really do want emoji, and I don't know why they want it in their terminal", that is.
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
changing it to wide would only cause destruction
🤣
|
Yeah, this looks like it covers all the ones I was concerned about. I'm still a little worried that we may not be in sync with other terminals, but we'll see how that goes. |
|
@msftbot merge this in 1 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 4 participants
A couple of codepoints, namely the card suites, male and female signs,
and white and black smiling faces were changed to have a two-column
width as part of #5795 since they were specified as emoji in Unicode's
emoji list v13.0[1].
These particular glyphs also show up in some of the most fundamental
code pages, such as CP437[2] and WGL4[3]. We should
not be touching the width of the glyphs in these codepages, as suddenly
changing a long-time-running narrow glyph to use two-columns all of a
sudden will surely break (and has already broken) things.
[1] https://www.unicode.org/Public/13.0.0/ucd/emoji/emoji-data.txt
[2] https://en.wikipedia.org/wiki/Code_page_437
[3] https://en.wikipedia.org/wiki/Windows_Glyph_List_4
Closes #5822