InteractivityWin32: Add a dependency on Dx#5851
Merged
DHowett-MSFT merged 1 commit intomasterfrom May 11, 2020
Merged
Conversation
Fixes #5819 (cherry picked from commit 124373d56f0289b6a29da647113f306525764202)
ghost
added
Area-Build
Contributor
Author
|
It might be more correct to remove the dependency from the dx header to the idl header. |
Contributor
Author
|
Failure - 1
This is not the issue this PR is intended to fix. /azp run |
zadjii-msft
approved these changes
May 11, 2020
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Run a few more builds but this should be fine IMO
Contributor
Author
failure 2[error]packages\Microsoft.Windows.CppWinRT.2.0.200316.3\build\native\Microsoft.Windows.CppWinRT.targets(164,13): Error MSB4006: There is a circular dependency in the target dependency graph involving target "ComputeGetResolvedWinMD". |
miniksa
approved these changes
May 11, 2020
Member
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
This is what I was going to do. Thanks for trying it before I could get to it.
Contributor
Author
|
/azp run |
Contributor
Author
|
PLAY IT AGAIN |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Four runs, 0 hits. Of note: I used to see it hit simultaneously with the recursive deps issue. I'm calling it. |
DHowett-MSFT
pushed a commit
that referenced
this pull request
May 12, 2020
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
microsoft#5743 introduced a dependency from _any consumer of the DX header_ to a header generated from an IDL file. Fixes microsoft#5819.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5743 introduced a dependency from any consumer of the DX header to a header generated from an IDL file.
I hope this fixes #5819. I'm going to run builds to find out.