Conversation
…s with git to fix
src/cascadia/TerminalApp/Tab.cpp
Outdated
| // calculate the luminance of the current color and select a font | ||
| // color based on that | ||
| // see https://www.w3.org/TR/WCAG20/#relativeluminancedef | ||
| // see http://www.w3.org/TR/WCAG20/#relativeluminancedef |
There was a problem hiding this comment.
i'd prefer not doing this one
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
it is not sufficient to leave a comment on the review, I have to type in another comment in this stupid box
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 28 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge this PR in like 2 minutes |
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
2 participants
I never got to fixing these in the original #3789 PR, but I messed up that branch way too many times already that I figured I'd just do it in post.
master