Added even more quick exit in InsertAttrRuns#5644
Conversation
|
Before:
After:
|
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
This is great, thanks!
@msftbot make sure @miniksa signs off on this
zadjii-msft
added
Area-Output
|
@msftbot make sure @miniksa signs off on this |
ghost
added
the
AutoMerge
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Bahahahahahahahahahaha. |
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
These are quite clever. Thanks!
|
@msftbot wait 1 minute before merge |
|
@msftbot merge this in 1 minute |
ghost
merged commit
|
🎉 Handy links: |
|
🎉 Once again, thanks for the contribution! This pull request was included in a set of conhost changes that was just |
5 participants
Summary of the Pull Request
In tonight's episode of "I wanna my CPU back", we'll see a quite familiar face whose name is Mr.AttrRow.
References
#2937
PR Checklist
Detailed Description of the Pull Request / Additional comments
I knew this is possible a long time ago. Just didn't got the chance to actually implement this. I understand that you guys are busy preparing the v1.0 release. So if this is a bad time, this can wait.
Validation Steps Performed
Manually tested. If all goes well, nothing will be broken.