Merged
Conversation
DHowett-MSFT
suggested changes
Apr 9, 2020
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
carlos-zamora
commented
Apr 10, 2020
carlos-zamora
commented
Apr 10, 2020
Member
Author
|
As a general question, when we provide a list of possible values in the schema, should we list the default value? I could honestly go either way. |
zadjii-msft
reviewed
Apr 14, 2020
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
I think I'm fine with this but I'm not a wordsmith so I'll the them be the official sign-offs
carlos-zamora
force-pushed
the
dev/cazamor/schema/nullable-colors
branch
from
6186fe0 to
84ebd21
Compare
cinnamon-msft
approved these changes
Apr 28, 2020
ghost
requested review from
DHowett-MSFT
approved these changes
Apr 28, 2020
DHowett-MSFT
pushed a commit
that referenced
this pull request
Apr 28, 2020
## Summary of the Pull Request This PR performs a number of miscellaneous clean-up tasks on our schema: - [X] allow null for some settings - [X] update some default values to be more useful - [X] consistently use " instead of ' - [X] remove colorTable - [X] provide missing description for `backgroundImageOpacity` - [X] update cursorShape to have options match order displayed in vs code - [X] if a setting has multiple options, provide a list of those options with a short description on each - this one I only did a few times - [X] remove a little bit of ambiguity on some descriptions ## PR Checklist Closes #5279 ## Detailed Description of the Pull Request / Additional comments Validation was performed for... - [X] Global Settings - [X] Profile Settings - [x] Keybinding Actions ## Validation Steps Performed I linked VS Code to the my version of the schema. Defined all settings from scratch in settings.json. Anytime I found something off, I updated the schema and saw if it looks right. (cherry picked from commit 9e23ee7)
|
🎉 Handy links: |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR performs a number of miscellaneous clean-up tasks on our schema:
backgroundImageOpacityPR Checklist
Closes #5279
Detailed Description of the Pull Request / Additional comments
Validation was performed for...
Validation Steps Performed
I linked VS Code to the my version of the schema. Defined all settings from scratch in settings.json. Anytime I found something off, I updated the schema and saw if it looks right.