Skip to content

Add 'copyFormatting' global setting#5299

Merged
2 commits merged intomasterfrom
dev/cazamor/html-global
Apr 9, 2020
Merged

Add 'copyFormatting' global setting#5299
2 commits merged intomasterfrom
dev/cazamor/html-global

Conversation

@carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Apr 9, 2020 •
edited
Loading

Summary of the Pull Request

Implements copyFormatting as a global setting. When enabled, formatting such as font and foreground/background colors are copied to the clipboard on all copy operations.

Also updates the schema and docs.

References

#5212 - Spec for Formatted Copying
#4191 - Setting to enable/disable formatted copy

#5263 - PR prematurely merged without approval of #5212

This feature will also have an impact on these yet-to-be-implemented features:

Detailed Description of the Pull Request

We already check if the hstring passed into the clipboard is empty before setting it. So the majority of the changes are actually just adding the global setting in.

Validation Steps Performed

copyFormatting Mouse Copy Keyboard Copy
not set (false) ✔ ✔
true ✔ ✔
false ✔ ✔

DHowett-MSFT
DHowett-MSFT suggested changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ ~ BLOCKING UNTIL THE SPEC MERGES ~ ~

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 9, 2020
@mcpiroman
Copy link
Contributor

mcpiroman commented Apr 9, 2020

Well, don't wanna complain and all, but technically this only closes #2690, not #4191 (actually the former happens to be already closed, because you apparently decided to not implement it back then).

This also looks like the implementation of option 1b from the spec at #5212, and what i was really into was the option 2b - it is what was originally requested (to split html from rtf) and is flexible so you can e.g. create separate commands for plain copy and html copy, which is common in other terminals, and is what some guy proposed in the original issue. I don't know your plans about that though, just throwing my opinion.

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Apr 9, 2020

To be fair, this is called out in the discussion section.

Question: Should this actually close #4191?
Yes: the sentiment behind this issue was to disable/enable formatted copy
No: the proposal was to copy specific formats
For now, I've assumed yes, but still wanted to point it out

@carlos-zamora
Copy link
Member Author

carlos-zamora commented Apr 9, 2020

Well, don't wanna complain and all, but technically this only closes #2690, not #4191 (actually the former happens to be already closed, because you apparently decided to not implement it back then).

This also looks like the implementation of option 1b from the spec at #5212, and what i was really into was the option 2b - it is what was originally requested (to split html from rtf) and is flexible so you can e.g. create separate commands for plain copy and html copy, which is common in other terminals, and is what some guy proposed in the original issue. I don't know your plans about that though, just throwing my opinion.

Yeah. The spec now says that #4191 will be implemented later. So you're right. Updating the PR header now

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 9, 2020
zadjii-msft
zadjii-msft approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait I already signed off on this

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Apr 9, 2020

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 9, 2020
@ghost
Copy link

ghost commented Apr 9, 2020

Hello @DHowett-MSFT!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 09 Apr 2020 23:32:13 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit ea1bb2e into master Apr 9, 2020
@ghost ghost deleted the dev/cazamor/html-global branch April 9, 2020 23:32
@DHowett-MSFT DHowett-MSFT mentioned this pull request Apr 17, 2020
Closed
@srdjanjovcic srdjanjovcic mentioned this pull request Jun 8, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

+1 more reviewer

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlos-zamora @mcpiroman @DHowett-MSFT @zadjii-msft