Skip to content

ci: update spelling allowlists/dictionaries#5124

Merged
DHowett-MSFT merged 1 commit intomicrosoft:masterfrom
jsoref:whitelist
Mar 25, 2020
Merged

ci: update spelling allowlists/dictionaries#5124
DHowett-MSFT merged 1 commit intomicrosoft:masterfrom
jsoref:whitelist

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 25, 2020

This is just some minor whitelisting/additions to dictionaries to catch up between when the spell checker PR was written and when it was finally merged.

This is basically taking the output from 499f24a#commitcomment-38053489 and putting it into files.

The choice of files is arbitrary. I'm adding a math.txt dictionary because it's a reasonable example.

The goal here is to get master to a green check mark

Summary of the Pull Request

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

When I pushed this commit to my fork, the spell check action ran and gave me a check mark:
https://github.com/jsoref/terminal/runs/534783276

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I can dig it

@DHowett-MSFT
Copy link
Contributor

admin override: this only touches non-code

@DHowett-MSFT DHowett-MSFT changed the title Updating whitelists/dictionaries ci: update spelling allowlists/dictionaries Mar 25, 2020
@DHowett-MSFT DHowett-MSFT merged commit f90239d into microsoft:master Mar 25, 2020
@jsoref jsoref deleted the whitelist branch March 25, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants