Only passthrough input changes if the client's in VT input mode#4913
Merged
DHowett-MSFT merged 3 commits intomasterfrom Mar 13, 2020
Merged
Only passthrough input changes if the client's in VT input mode#4913DHowett-MSFT merged 3 commits intomasterfrom
DHowett-MSFT merged 3 commits intomasterfrom
Conversation
zadjii-msft
added
Area-VT
DHowett-MSFT
approved these changes
Mar 13, 2020
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
This looks sane to me. I'm going to test it, of course, but it looks sane to me.
Contributor
|
I did test this, and it works fine with SSH and doesn't break wsl mouse mode. |
carlos-zamora
approved these changes
Mar 13, 2020
DHowett-MSFT
changed the title
carlos-zamora
added a commit
that referenced
this pull request
Apr 16, 2020
1 task
ghost
pushed a commit
that referenced
this pull request
Apr 17, 2020
## Summary of the Pull Request Adds SS3 cursor encoding for cursor keys and home/end button. Reverts a portion of #4913 that checks for VT Input Mode. ## PR Checklist * [X] Closes #4873 ## Validation Steps Performed 1. Open pwsh 2. run `wsl` 3. execute `printf "\e[?1h"` 4. verify keys work 5. exit back to pwsh 6. verify keys work still (didn't previously) Also verified that those keys work in vim when connected to my Raspberry Pi over SSH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hack to fix #4911. I cannot stress enough that I haven't tested this, but it's 5pm on a Friday here in Wisconsin, and I'm hoping that the rest of the team will validate this 😝