Fire UIA Events for Output and Cursor Movement by carlos-zamora · Pull Request #4826 · microsoft/terminal

carlos-zamora · 2020-03-06T18:04:50Z

Summary of the Pull Request

This notifies automation clients (i.e.: NVDA, narrator, etc...) of new output being rendered to the screen.

References

Close #2447 - Signaling for new output and cursor
Close #3791 - fixed by signaling cursor changes

Detailed Description of the Pull Request / Additional comments

Added tracing for UiaRenderer. This makes it easier to debug issues with notifying an automation client.
Fire TextChanged automation events when new content is output to the screen.

Validation Steps Performed

Verified with NVDA [1]

Narrator

Narrator works better, but is unable to detect new output consistently. There is no harm for narrator when this change goes in.

[1] #2447 (comment)

carlos-zamora · 2020-03-06T18:05:37Z

I meant to publish this PR as a draft but I guess there's no undo button...

codeofdusk · 2020-03-07T22:08:55Z

This PR allows NVDA to fully support Terminal. Corresponding NVDA-side changes are in nvaccess/nvda#10784.

zadjii-msft

I suppose I'm holding my check to see what else narrator needs, but so far looks good

src/types/UiaTracing.cpp

DHowett-MSFT · 2020-03-13T00:24:43Z

/azp run

azure-pipelines · 2020-03-13T00:24:52Z

Azure Pipelines successfully started running 1 pipeline(s).

carlos-zamora · 2020-03-13T16:41:14Z

Given the latest commit, looks like NVDA 2020.1 works fine.
But Narrator gets worse and crashes on any input...

EDIT: this also crashes accevent. So this leads me to believe that something bad is going on with dispatching our CursorChanged event.

miniksa · 2020-03-17T15:55:46Z

This is me noting that I saw this PR and am not reviewing at this time because @carlos-zamora says there's still some nasty crash.

codeofdusk · 2020-03-17T21:17:08Z

Any chance this PR could be merged without 522b99a and the rest of the event support (for Narrator) Could be added in subsequent PRs? This would allow NVDA to support Terminal.

leonMSFT

Looks pretty straightforward to me 🚀

src/cascadia/TerminalControl/TermControlAutomationPeer.cpp

zadjii-msft

I'd really love a comment where Leon called out, but sure

ghost · 2020-03-18T18:00:50Z

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

## Summary of the Pull Request This notifies automation clients (i.e.: NVDA, narrator, etc...) of new output being rendered to the screen. ## References Close #2447 - Signaling for new output and cursor Close #3791 - fixed by signaling cursor changes ## Detailed Description of the Pull Request / Additional comments - Added tracing for UiaRenderer. This makes it easier to debug issues with notifying an automation client. - Fire TextChanged automation events when new content is output to the screen. ## Validation Steps Performed Verified with NVDA [1] ## Narrator Narrator works _better_, but is unable to detect new output consistently. There is no harm for narrator when this change goes in. [1] #2447 (comment)

codeofdusk · 2020-04-21T23:57:16Z

Any idea when this PR will make it to Windows Store users?

DHowett-MSFT · 2020-04-22T01:58:39Z

Aiming for tomorrow.

codeofdusk · 2020-04-22T02:38:56Z

Wow, that was good timing!

ghost · 2020-04-22T17:17:00Z

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

codeofdusk mentioned this pull request Mar 6, 2020

Add support for Windows Terminal nvaccess/nvda#10784

Merged

zadjii-msft added Area-Accessibility Issues related to accessibility Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. labels Mar 9, 2020

zadjii-msft reviewed Mar 9, 2020

View reviewed changes

src/types/UiaTracing.cpp Outdated Show resolved Hide resolved

carlos-zamora mentioned this pull request Mar 9, 2020

Accessibility: Signaling Model #2447

Closed

5 tasks

carlos-zamora added 2 commits March 12, 2020 16:20

Signaling Output - v1

c588844

undo comment

56bfc6b

carlos-zamora force-pushed the dev/cazamor/acc/sig/output branch from 729de14 to 56bfc6b Compare March 12, 2020 23:58

signal cursor changed events

522b99a

carlos-zamora changed the title ~~Fire UIAutomation Events for Output~~ Fire UIA Events for Output and Cursor Movement Mar 13, 2020

carlos-zamora added 2 commits March 17, 2020 14:37

appropriately send cursor events.

00ee354

fix tracing

457ee3c

leonMSFT approved these changes Mar 18, 2020

View reviewed changes

src/cascadia/TerminalControl/TermControlAutomationPeer.cpp Show resolved Hide resolved

zadjii-msft approved these changes Mar 18, 2020

View reviewed changes

add comment on bad event

6214d6b

carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 18, 2020

ghost merged commit eca0c6b into master Mar 18, 2020

ghost deleted the dev/cazamor/acc/sig/output branch March 18, 2020 18:01

ghost mentioned this pull request Apr 22, 2020

Text Cursor Indicator does not move with cursor #3791

Closed

chinwobble mentioned this pull request Sep 20, 2020

Add screen reader support onivim/oni2#2489

Open

This pull request was closed.

Conversation

carlos-zamora commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

References

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Narrator

Uh oh!

carlos-zamora commented Mar 6, 2020

Uh oh!

codeofdusk commented Mar 7, 2020

Uh oh!

zadjii-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DHowett-MSFT commented Mar 13, 2020

Uh oh!

azure-pipelines bot commented Mar 13, 2020

Uh oh!

carlos-zamora commented Mar 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miniksa commented Mar 17, 2020

Uh oh!

codeofdusk commented Mar 17, 2020

Uh oh!

leonMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zadjii-msft left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Mar 18, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

codeofdusk commented Apr 21, 2020

Uh oh!

DHowett-MSFT commented Apr 22, 2020

Uh oh!

codeofdusk commented Apr 22, 2020

Uh oh!

ghost commented Apr 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

carlos-zamora commented Mar 6, 2020 •

edited

Loading

carlos-zamora commented Mar 13, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.