Merged
Conversation
carlos-zamora
added
Area-Accessibility
DHowett-MSFT
previously approved these changes
Feb 7, 2020
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
I don't totally understand: it makes the tracing compile, but it doesn't actually enable many of the commented-out traces?
Contributor
|
sorry, i was just looking at one commit. re-reviewing. |
ghost
added
Needs-Author-Feedback
…4526) ## Summary of the Pull Request `ScreenInfoUiaProvider::GetVisibleRanges()` used to return one range per line of visible text. The documentation for this function says that we should return one per contiguous span of text. Since all of the text in the TermControl will always be contiguous (at least by our standards), we should only ever be returning one range. ## PR Checklist * [X] Closes #4507 * [X] CLA signed. ## Validation Steps Performed Verified using Accessibility Insights.
Contributor
|
oop this one got another PR merged into it |
carlos-zamora
changed the title
miniksa
requested changes
Feb 11, 2020
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
Contributor
|
I've updated the PR description to include the GetVisibleRanges change. |
2 tasks
DHowett-MSFT
approved these changes
Feb 20, 2020
miniksa
approved these changes
Feb 20, 2020
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
codeofdusk
added a commit
to codeofdusk/nvda
that referenced
this pull request
Feb 23, 2020
codeofdusk
added a commit
to codeofdusk/nvda
that referenced
this pull request
Apr 1, 2020
michaelDCurran
pushed a commit
to nvaccess/nvda
that referenced
this pull request
Apr 6, 2020
* Bring over ConsoleUIATextInfo refactoring from #10716. * Add WinTerminalUIA * Style. * Review actions. * microsoft/terminal#4495: support fixed GetVisibleRanges. * KeyboardHandlerBasedTypedCharSupport -> EnhancedTermTypedCharSupport, add _shouldUseToUnicodeEx flag and set False for WinTerminalUIA. * Update doc comments. * Update copyrights. * Review actions. * Factor out bounding into separate method. * Re-introduce KeyboardHandlerBasedTypedCharSupport. * Fix UIA console support for newer Windows Console builds. * Revert copyright header changes. * Revert another no longer necessary copyright header change. * Fix comments. * Update docstring. * Review actions. * Update source/NVDAObjects/behaviors.py Co-Authored-By: Leonard de Ruijter <[email protected]> * Add class docstring. * Optimization: clear character buffers when reporting new lines. This saves us from scanning the old and new lines twice in _calculateNewText (once for diffing and once for finding nonblank indices), and fixes typed word reporting for 21H1 console. This new approach does not resolve #10942. * Update inaccurate information in user guide. Co-authored-by: Leonard de Ruijter <[email protected]>
This was referenced Apr 8, 2020
Closed
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Debugging our custom UIA providers has been a painful experience because outputting content to VS may result in UIA Clients getting impatient and giving up on extracting data.
Adding tracing allows us to debug these providers without getting in the way of reproducing a bug. This will help immensely with developing accessibility features on Windows Terminal and Console.
This pull request additionally contains payload from #4526:
ScreenInfoUiaProvider::GetVisibleRanges()used to return one range per line of visible text. The documentation for this function says that we should return one per contiguous span of text. Since all of the text in the TermControl will always be contiguous (at least by our standards), we should only ever be returning one range.PR Checklist
Detailed Description of the Pull Request / Additional comments
UiaTracingis a singleton class that is in charge of registration for trace logging.TextRangeis used to traceUiaTextRange, whereasTextProvideris used to traceScreenInfoUiaProviderBase._getValue()is overloaded to transform complex objects and enums into a string for logging._getTextValue()had to be added to be able to trace the text a UiaTextRange included. This makes following UiaTextRanges much simpler.Validation Steps Performed
Performed a few operations when under NVDA/Narrator and manually checked the results.