Skip to content

spelling: attribute#4469

Closed
jsoref wants to merge 1 commit intomicrosoft:masterfrom
jsoref:spelling-attribute
Closed

spelling: attribute#4469
jsoref wants to merge 1 commit intomicrosoft:masterfrom
jsoref:spelling-attribute

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 5, 2020

Summary of the Pull Request

split out per @miniksa

References

#4295 (review)

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@jsoref jsoref force-pushed the spelling-attribute branch from adc7d9e to 22ffd4a Compare February 5, 2020 00:59
@jsoref jsoref mentioned this pull request Feb 5, 2020
Merged
miniksa
miniksa approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but this cannot be merged in and replicated quite as such. We will probably need to fix it in the Windows side and flow it back out.

@miniksa
Copy link
Member

miniksa commented Feb 10, 2020

Attempting this right now on the Windows side in user/miniksa/spelling...

@miniksa
Copy link
Member

miniksa commented Feb 10, 2020

This is now MSFT:25154975

@miniksa
Copy link
Member

miniksa commented Feb 10, 2020

Committed today in PR:4297546 on the inside. @DHowett-MSFT will replicate it out and then this PR can probably be closed.

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Feb 12, 2020

Ugh: I misspelled it in the commit message. This merged in with bb4cd64. Thanks for your patience!

@jsoref jsoref deleted the spelling-attribute branch February 12, 2020 20:58
@jsoref
Copy link
Contributor Author

jsoref commented Feb 12, 2020

That's ok, the commit message for the original spelling PR is also pretty embarrassing. I didn't really expect the bot to take the description as the commit message (it had a note which was no longer applicable).

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Feb 12, 2020

Yeah, that's something we can always do with more work on. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miniksa miniksa miniksa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoref @miniksa @DHowett-MSFT