Fix matches of multiple schemas on "profiles"#4045
Merged
zadjii-msft merged 1 commit intomicrosoft:masterfrom Dec 30, 2019
Merged
Fix matches of multiple schemas on "profiles"#4045zadjii-msft merged 1 commit intomicrosoft:masterfrom
zadjii-msft merged 1 commit intomicrosoft:masterfrom
Conversation
DHowett-MSFT
approved these changes
Dec 24, 2019
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Wow, that’s really subtle. Thanks!
I’ll sign off on this, but our two-reviewer policy might make it a little hard to get a change in over Christmas :)
zadjii-msft
approved these changes
Dec 30, 2019
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Jeez why didn't my json schema validator not catch that this schema was missing this :P?
Contributor
Author
|
@zadjii-msft just in case you are interested. Looks like VS Code relies on validation provided by vscode-json-languageservice package. |
carlos-zamora
pushed a commit
that referenced
this pull request
Jul 27, 2023
Adds proper `type` for `SchemePair` definition to avoid warnings about matches of multiple schemas. Same fix as #4045 ## Validation Steps Performed - Pointed $schema to local file instead of https://aka.ms/terminal-profiles-schema - Confirmed warning goes away when using a string - Confirmed using the light/dark object format still passes validation - Confirmed values like `"colorScheme": 3` no longer incorrectly pass validation whereas they would before
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
Adds proper `type` for `SchemePair` definition to avoid warnings about matches of multiple schemas. Same fix as #4045 ## Validation Steps Performed - Pointed $schema to local file instead of https://aka.ms/terminal-profiles-schema - Confirmed warning goes away when using a string - Confirmed using the light/dark object format still passes validation - Confirmed values like `"colorScheme": 3` no longer incorrectly pass validation whereas they would before (cherry picked from commit 57b9549) Service-Card-Id: 90012052 Service-Version: 1.17
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
Adds proper `type` for `SchemePair` definition to avoid warnings about matches of multiple schemas. Same fix as #4045 ## Validation Steps Performed - Pointed $schema to local file instead of https://aka.ms/terminal-profiles-schema - Confirmed warning goes away when using a string - Confirmed using the light/dark object format still passes validation - Confirmed values like `"colorScheme": 3` no longer incorrectly pass validation whereas they would before (cherry picked from commit 57b9549) Service-Card-Id: 90012053 Service-Version: 1.18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds proper
typeforProfilesObjectdefinition to avoid warnings about matches of multiple schemas.References
Original issue: #3909
Related PR: #3892
Relates VSCode issue: microsoft/vscode#86738
PR Checklist
Tests added/passedRequires documentation to be updatedDetailed Description of the Pull Request / Additional comments
Validation Steps Performed
doc/cascadia/profiles.schema.jsonlocallyprofiles.jsonfrom WT in VSCode$schemavalue with path to local copy (verified that all errors are still in place and validations works as before)typeonProfilesObjectMatches multiple schemas when only one must validatewarning is fixed