Apply audit mode to TerminalInput/Adapter/Parser libraries#4005
Conversation
…structs, propagate changes out.
…eferences, string views, standard types.
…ng string views everywhere, size_ts over smaller sizes in prep for massive buffers, and so on and so on.
…ing used for calling ProcessString on the parser in the tests.
…sts. Fixed some rule of 5s, suppressed others. Suppressed constexpr suggestions. Use narrow_cast where applicable. Consts on unchanged variables. .at() for array accesses, and so on.
… constexpr and gluing everything back together. Otherwise, the usual suspects of array-to-pointer decay and noexcepts and whatnot.
zadjii-msft
left a comment
There was a problem hiding this comment.
Yea this one's good too. Okay, no more reviews from me today :P
DHowett-MSFT
left a comment
There was a problem hiding this comment.
I'm NAKing out of this PR early to mark it red, but I'll keep reviewing.
Nit: please reword the PR title to be imperative, and as though it was completing the sentence "This pull request will ...".
…de (and in the future do conversions and whatnot safelyish). Use it to bypass the warnings in a methodic way for where we already know the bounds FOR SURE. Also, try to adjust some of adapt dispatch's arithmetic to make it not substantially worse and still pass audit before we get to improving our safemath library.
… a few other odds and ends.
…ach file. Run code format.
… pass. We can adjust the behavior re: clamping later.
miniksa
left a comment
There was a problem hiding this comment.
(What happened here? a revert?)
Yeah, I thought the GitHub UI would allow me to revert one file in one commit. Turns out it made me revert a lot more than that.
|
Gotta run to an appointment. If this succeeds everything, then we'll merge it at the next opportunity and move on to gardening3_audit2. |
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Summary of the Pull Request
PR Checklist
_Generate*Sequence()to usewil::str_printf#3957Detailed Description of the Pull Request / Additional comments
This is turning on the auditing of these projects (as enabled by the heavier lifting in the other refactor) and then cleaning up the remaining warnings.
Validation Steps Performed