Merged
Conversation
On this month's episode of "Mike accidentally breaks this": Mike forgets that `==` is defined on a pair of winrt objects as "do these point to the _SAME_ object", not "do they have the same values". This just slipped right through code review.
zadjii-msft
requested review from
DHowett-MSFT,
carlos-zamora,
leonMSFT and
miniksa
zadjii-msft
added
Area-UserInterface
| if (otherAsUs) | ||
| { | ||
| return otherAsUs->_TerminalArgs == _TerminalArgs; | ||
| return otherAsUs->_TerminalArgs.Equals(_TerminalArgs); |
Contributor
There was a problem hiding this comment.
I think we actually need a less strict check than this, right? like: if I bind a profile guid, name OR index to newTab, should it show up in the list?
DHowett-MSFT
approved these changes
Dec 10, 2019
carlos-zamora
approved these changes
Dec 11, 2019
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 33 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
On this month's episode of "Mike accidentally breaks this":
Mike forgets that
==is defined on a pair of winrt objects as "do these point to the SAME object", not "do they have the same values".This just slipped right through code review.
References
Broken in #3825
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Manually checked that these are still there