Merged
Conversation
(cherry picked from commit 2e522f4)
zadjii-msft
added
Area-UserInterface
zadjii-msft
requested review from
DHowett-MSFT,
carlos-zamora,
leonMSFT and
miniksa
DHowett-MSFT
approved these changes
Dec 10, 2019
| std::optional<int> _rearrangeTo; | ||
|
|
||
| ShortcutActionDispatch _actionDispatch{}; | ||
| winrt::com_ptr<ShortcutActionDispatch> _actionDispatch{ winrt::make_self<ShortcutActionDispatch>() }; |
Contributor
There was a problem hiding this comment.
this perturbs me a bit. something about the complex initializer statement in the header, idk
carlos-zamora
approved these changes
Dec 11, 2019
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 1 hour 14 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
I accidentally did the wrong check here to see if the value exists. For an
IReference, you need to dovariable != nullptr. I didvariable.Value().References
Introduced in #3825
PR Checklist
{"action": "newTab", "profile": "NameOfProfile"}binding causes a crash #3897Detailed Description of the Pull Request / Additional comments
This includes a maybe unrelated fix to make
TerminalPage'sShortcutActionDispatchacom_ptr. While I was messing with the tests for this, I caught that we're not supposed to direct allocate winrt types like that. Ofc, theTerminalAppLibproject doesn't catch this.Validation Steps Performed
Ran the terminal manually, instead of just running the tests