Re-add keybindings to new tab dropdown#3618
Merged
zadjii-msft merged 3 commits intomasterfrom Nov 21, 2019
Merged
Conversation
zadjii-msft
added
Area-UserInterface
DHowett-MSFT
approved these changes
Nov 18, 2019
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Joke about expense aside, thanks for fixing 😄
| // If NewTabProfileN didn't have a binding, look for a | ||
| // keychord that is bound to the equivalent | ||
| // NewTab(ProfileIndex=N) action | ||
| auto actionAndArgs = winrt::make_self<winrt::TerminalApp::implementation::ActionAndArgs>(); |
ghost
requested review from
carlos-zamora
approved these changes
Nov 18, 2019
zadjii-msft
commented
Nov 18, 2019
Co-Authored-By: Carlos Zamora <[email protected]>
Member
Author
|
I can't block my own change, but this needs to be merged nicely with #3629 |
# Conflicts: # src/cascadia/TerminalApp/ActionArgs.h
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
With #3391, I almost certainly regressed the ability for the new tab dropdown to display the keybindings for each profile. This adds them back.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Now, we can lookup keybindings not only for
ShortcutActions, but alsoActionAndArgss, so we can look up the binding for an action with a particular set of arguments.