Skip to content

Added default keybindings for panes#3585

Merged
cinnamon-msft merged 5 commits intomasterfrom
cinnamon/default-pane-keybindings
Nov 19, 2019
Merged

Added default keybindings for panes#3585
cinnamon-msft merged 5 commits intomasterfrom
cinnamon/default-pane-keybindings

Conversation

@cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Nov 14, 2019

Summary of the Pull Request

Added the following keybindings for panes:

	{ "command": "splitHorizontal", "keys": [ "alt+shift+-" ] },
        { "command": "splitVertical", "keys": [ "alt+shift+plus" ] },
        { "command": { "action": "moveFocus", "direction":"down" }, "keys": [ "alt+down" ] },
        { "command": { "action": "moveFocus", "direction":"left" }, "keys": [ "alt+left" ] },
        { "command": { "action": "moveFocus", "direction":"right" }, "keys": [ "alt+right" ] },
        { "command": { "action": "moveFocus", "direction":"up" }, "keys": [ "alt+up" ] },
        { "command": { "action": "resizePane", "direction":"down" }, "keys": [ "alt+shift+down" ] },
        { "command": { "action": "resizePane", "direction":"left" }, "keys": [ "alt+shift+left" ] },
        { "command": { "action": "resizePane", "direction":"right" }, "keys": [ "alt+shift+right" ] },
        { "command": { "action": "resizePane", "direction":"up" }, "keys": [ "alt+shift+up" ] },

References

PR Checklist

  • Closes Set panes keybindings by default #3544
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@zadjii-msft zadjii-msft mentioned this pull request Nov 14, 2019
Open
59 tasks
DHowett-MSFT
DHowett-MSFT suggested changes Nov 14, 2019
View reviewed changes
@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 14, 2019
zadjii-msft
zadjii-msft reviewed Nov 14, 2019
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I obviously approve, but I want this discussion to run it's course before I sign off.

carlos-zamora
carlos-zamora approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. I know @DHowett-MSFT had some feelings about using the alt key though

@cinnamon-msft cinnamon-msft merged commit d1e9de7 into master Nov 19, 2019
@cinnamon-msft cinnamon-msft deleted the cinnamon/default-pane-keybindings branch November 19, 2019 18:00
@ghost
Copy link

ghost commented Nov 26, 2019

🎉Windows Terminal Preview v0.7.3291.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 26, 2019
Closed
@paulwhiting paulwhiting mentioned this pull request Nov 27, 2019
Closed
@bchap1n
Copy link

bchap1n commented Dec 1, 2019

is there a way to close a split pane? It seems too easy to open one too many panes.

@zadjii-msft
Copy link
Member

zadjii-msft commented Dec 2, 2019

@bchap1n The default keybinding for "Close Tab" (ctrl+shift+w) is actually secretly bound to "Close Pane". It just so happens that when you have only one pane in a tab, it'll close the pane too 😜

@mcornella
Copy link

mcornella commented Dec 4, 2019

@DHowett-MSFT the default keybinding for "split vertically" says to use = (equal) instead of + (plus) in the release changelog.

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Dec 4, 2019

Yes, I erroneously oversimplified it based on my US 104-key keyboard (where it is impossible to press Alt+Shift+Plus without pressing Alt+Shift+=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zadjii-msft zadjii-msft zadjii-msft left review comments

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

+1 more reviewer

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set panes keybindings by default

6 participants

@cinnamon-msft @bchap1n @zadjii-msft @mcornella @DHowett-MSFT @carlos-zamora