Move project to app CRTs in preparation to run Universal#3474
Merged
Move project to app CRTs in preparation to run Universal#3474
Conversation
… it'll use the CRT inside TerminalConnection (or its other consumers) instead of linking its own.
… on how CRT linking works for future reference. I'm sure this will come up again.
DHowett-MSFT
changed the title
DHowett-MSFT
approved these changes
Nov 7, 2019
zadjii-msft
approved these changes
Nov 8, 2019
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Sad to see the final nail in the unpackaged coffin. I had hoped to resurrect that monster at some point in the future, but this definitely takes priority over my monster.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 13, 2019
Contributor
|
Note to self: Reports that this has different results for Unicode rendering (???) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
We were overriding to the desktop SDK for our terminal project for reasons related to unpackaged activation. But:
In order for me to get this to run on non-Desktop platforms, I need the universal app CRT instead. So this uses that by default.
One casualty of war is winconpty.dll. If I build it in DLL form since it's a non-store project, it gets the desktop CRT. But the now-universal TerminalConnection.dll project dependent on the app CRT needs that.
I could set winconpty.dll to the store/app crt... and then the tests would break unless I carried the forwarders with.
So since there's no pressing need to distribute the winconpty.dll as a DLL, I made it a .lib and let it get rolled into the relevant binaries that already have their platform-appropriate CRTs.
Validation Steps Performed
F5-ran the CascadiaPackage project