Move AzureConnection's strings into localizable resources#3463
Merged
DHowett-MSFT merged 4 commits intomasterfrom Nov 7, 2019
Merged
Move AzureConnection's strings into localizable resources#3463DHowett-MSFT merged 4 commits intomasterfrom
DHowett-MSFT merged 4 commits intomasterfrom
Conversation
DHowett-MSFT
added
the
Area-AzureShell
Contributor
Author
|
Please don't comment on the ResX schema comment. It's not removable. VS just adds it back every single time you save. |
Contributor
Author
|
Yes, even with its spelling errors. |
miniksa
approved these changes
Nov 7, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This also sets up TerminalConnection to have resources, which will be useful for the messaged in #3461.
This pull request does not adjust any of the state machine logic, but a following one will.
References
This was untracked work that was mentioned in passing in #2146 .
PR Checklist
Validation Steps Performed
Walked through the Azure connection myself.