Replace ConhostConnection with ConptyConnection#3461
Merged
DHowett-MSFT merged 5 commits intomasterfrom Nov 6, 2019
Merged
Conversation
Contributor
Author
|
There's an argument to be made that I should be using the modern threadpooling APIs, but.. that would require us to have a shared threadpool onto which all work gets dispatched instead of letting the system manage one for us. Why would we not want the system to manage one for us? |
Member
Per offline discussion, plx try it. |
Contributor
Author
|
Done, and fixed SA too. |
DHowett-MSFT
force-pushed
the
dev/duhowett/die_conhostconnection_ist
branch
from
932775a to
8bde4c2
Compare
This commit deletes ConhostConnection and replaces it with ConptyConnection. The ConptyConnection uses CreatePseudoConsole and depends on winconpty to override the one from kernel32. * winconpty must be packagebale, so I've added GetPackagingOutputs. * To validate this, I added conpty.dll to the MSIX regression script. * I moved the code from conpty-universal that deals with environment strings into the types library. This puts us in a way better place to implement #2563, as we can now separately detect a failure to launch a pseudoconsole, a failure to CreateProcess, and a failure of the launched process. Fixes #1131.
DHowett-MSFT
force-pushed
the
dev/duhowett/die_conhostconnection_ist
branch
from
8bde4c2 to
01a146f
Compare
miniksa
requested changes
Nov 6, 2019
ghost
added
Needs-Author-Feedback
5 tasks
Co-Authored-By: Mike Griese <[email protected]>
Contributor
Author
|
I am using my admin powers because 1. the only change was in a comment and 2. code formatter phase passed |
Contributor
Author
889 deletions is pretty good. |
DHowett-MSFT
pushed a commit
that referenced
this pull request
Nov 7, 2019
This also sets up TerminalConnection to _have_ resources, which will be useful for the messages in #3461.
|
🎉 Handy links: |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deletes ConhostConnection and replaces it with
ConptyConnection. The ConptyConnection uses CreatePseudoConsole and
depends on winconpty to override the one from kernel32.
strings into the types library.
This puts us in a way better place to implement #2563, as we can now
separately detect a failure to launch a pseudoconsole, a failure to
CreateProcess, and a failure of the launched process.
Fixes #1131.
References
Relevant to #2563.
PR Checklist
Validation Steps Performed
Launched WT a bunch, with shells and pseudoterminal hosts that didn't exist, and killed various processes all over the tree.