Propagate window style changes to the titlebar and minmax#3025
Merged
carlos-zamora merged 1 commit intomasterfrom Oct 2, 2019
Merged
Propagate window style changes to the titlebar and minmax#3025carlos-zamora merged 1 commit intomasterfrom
carlos-zamora merged 1 commit intomasterfrom
Conversation
DHowett-MSFT
commented
Oct 1, 2019
| switch (visualState) | ||
| { | ||
| case WindowVisualState::WindowVisualStateMaximized: | ||
| winrt::Windows::UI::Xaml::VisualStateManager::GoToState(MaximizeButton(), L"WindowStateMaximized", false); |
Contributor
Author
There was a problem hiding this comment.
i do not yet intend to unify these string names. sorry.
zadjii-msft
approved these changes
Oct 2, 2019
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Thanks for doing my work for me :P
|
|
||
| if (_titlebar) | ||
| { | ||
| _titlebar.SetWindowVisualState(isMaximized ? winrt::TerminalApp::WindowVisualState::WindowVisualStateMaximized : |
Member
There was a problem hiding this comment.
my only complaint is that these lines are too damn long. But that's a stylistic choice for someone with split panes in their editor :)
zadjii-msft
added
Area-UserInterface
ghost
requested review from
carlos-zamora
approved these changes
Oct 2, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Detailed Description of the Pull Request / Additional comments
This also sets us up for a bit more robustness down the line.
Validation Steps Performed
Really went ham on ways to minmax the window.