Patch fix for #1360 until WriteStream (#780) can be implemented.#2924
Merged
4 commits merged intomasterfrom Oct 1, 2019
Merged
Patch fix for #1360 until WriteStream (#780) can be implemented.#29244 commits merged intomasterfrom
4 commits merged intomasterfrom
Conversation
Member
Author
|
Same code snippet against conhost doesn't crash, so I don't believe there's anything to fix there right now. This makes sense since it should hit the OG |
zadjii-msft
reviewed
Sep 27, 2019
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
For the record, I'm on board shipping this. I can't imagine blocking over something in test code, but I'll patiently wait for the test to sign off
…tat. Writes a bisecting character to the right most cell in the window.
zadjii-msft
approved these changes
Sep 27, 2019
Contributor
|
|
DHowett-MSFT
approved these changes
Sep 28, 2019
5 tasks
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HBelusca
reviewed
Oct 1, 2019
| } | ||
|
|
||
| // If we're about to try to place the cursor past the right edge of the buffer, move it down a row | ||
| // This is another patch that GH#780 should supercede. This is really correcting for other bad situations |
DHowett-MSFT
reviewed
Oct 1, 2019
ghost
merged commit 
DHowett-MSFT
pushed a commit
that referenced
this pull request
Oct 16, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
5 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Writing can enter an infinite loop with full-width characters being inserted into the last column of the buffer.
References
#780
PR Checklist
Detailed Description of the Pull Request / Additional comments
This is because the "WriteCharsLegacy2ElectricBoogaloo" implementation in the Terminal (
Terminal::_WriteBuffer) is a hacky thing that we put together knowing full well that we'd have to do #780 but we had to get this working enough for now. Turns out, it's not super complete and fragile. Surprise.Validation Steps Performed