Fix json settings documentation#2699
Merged
miniksa merged 2 commits intomicrosoft:masterfrom Sep 10, 2019
Merged
Conversation
The ctrl+c issue was fixed in [microsoft#2446](microsoft#2446)
Contributor
Author
|
I could have changed the text to this: Note: If you set your copy keybinding to Thoughts? |
Member
I definitely prefer that text. I'd also leave the note about Ctrl+V, because that's still relevant. |
Contributor
|
Yeah, I like the text change. Ctrl+V is also still worth calling out. Thanks for working on our docs! |
zadjii-msft
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
Contributor
Author
|
@zadjii-msft @DHowett-MSFT: Updated! Thanks |
carlos-zamora
approved these changes
Sep 10, 2019
miniksa
approved these changes
Sep 10, 2019
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ctrl+c issue was fixed in #2446
Release:
Windows Terminal Preview v0.4.2382.0