Skip to content

Delimiter Runs#2552

Merged
carlos-zamora merged 1 commit intodev/cazamor/misc-selection-tasksfrom
dev/cazamor/delimiter-runs
Aug 26, 2019
Merged

Delimiter Runs#2552
carlos-zamora merged 1 commit intodev/cazamor/misc-selection-tasksfrom
dev/cazamor/delimiter-runs

Conversation

@carlos-zamora
Copy link
Member

You can ignore this PR. I thought delimiter runs was gonna be more work. Turns out, it was super easy.

Targetting to my misc-selection-tasks branch and merging immediately. I guess use this as a diff if you want?

Add test (caught a minor thing because of that)
@carlos-zamora carlos-zamora merged commit 6fd44cf into dev/cazamor/misc-selection-tasks Aug 26, 2019
@carlos-zamora carlos-zamora deleted the dev/cazamor/delimiter-runs branch August 26, 2019 23:28
DHowett-MSFT pushed a commit that referenced this pull request Sep 17, 2019
* Test: out of bounds selection
* Clean up Selection code:
- selectionVerticalOffset
- proper return values (const)
- Break up GetSelectionRects()

* Fix Delimiter Text Runs (#2552)

* Added helper method and some log comments throughout tests

Closes #1327.
Closes #2261.
Closes #2206.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant