When the titlebar is clicked, dismiss the new tab flyout#2438
Merged
2 commits merged intomasterfrom Aug 16, 2019
Merged
Conversation
zadjii-msft
added
Area-UserInterface
miniksa
approved these changes
Aug 15, 2019
carlos-zamora
requested changes
Aug 16, 2019
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Bug still happens when "showTabsInTitlebar": true
ghost
added
Needs-Author-Feedback
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
carlos-zamora
approved these changes
Aug 16, 2019
ghost
merged commit
This was referenced Aug 20, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Oct 27, 2020
Close the tab context menu when clicking on the title bar ## Detailed Description of the Pull Request / Additional comments Following #2438, hide the tabs context menu on `TerminalPage::TitlebarClicked()`. We don't know which of the tabs is showing the context menu, do it on all tabs. ## Validation Steps Performed Open the context menu from any tab, click on title bar and see the context menu disappear. Closes #7988
DHowett
pushed a commit
that referenced
this pull request
Oct 28, 2020
Close the tab context menu when clicking on the title bar ## Detailed Description of the Pull Request / Additional comments Following #2438, hide the tabs context menu on `TerminalPage::TitlebarClicked()`. We don't know which of the tabs is showing the context menu, do it on all tabs. ## Validation Steps Performed Open the context menu from any tab, click on title bar and see the context menu disappear. Closes #7988 (cherry picked from commit 7e86001)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Appto indicate to the app that the titlebar has been clicked. We'll use this method toHidethe flyout.NonClientIslandWindow, treat the titlebar asHTNOWHERE, so we get clicks in that area.NonClientIslandWindow, raise an event when the titlebar area is clicked. Also do the normalHTCAPTIONthing we were doing before.AppHost, when it handles the event fromNonClientIslandWindow, it'll call the method onAppto close the flyout.PR Checklist