Fix test runner commands - runut.cmd and friends; PowerShell Invoke-OpenConsoleTests#2020
Merged
carlos-zamora merged 1 commit intomicrosoft:masterfrom Jul 18, 2019
Merged
Conversation
…sts) In commit 0905140 (PR microsoft#1164), we updated the version of the Taef.Redist.Wlk NuGet package for the TAEF test harness and framework. However, the helper commands to run the various test cases hard-code the path to the TAEF executable, which because of NuGet's design includes the TAEF NuGet package version. These commands weren't updated to reflect the new TAEF version and so have been broken since then. This commit fixes the issue and makes running tests possible again.
zadjii-msft
approved these changes
Jul 18, 2019
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Great catch - I don't think I saw this since I still had the old TAEF package laying around at that path, it just worked for me. Thanks for finding this!
carlos-zamora
approved these changes
Jul 18, 2019
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
…sts) (microsoft#2020) In commit 0905140 (PR microsoft#1164), we updated the version of the Taef.Redist.Wlk NuGet package for the TAEF test harness and framework. However, the helper commands to run the various test cases hard-code the path to the TAEF executable, which because of NuGet's design includes the TAEF NuGet package version. These commands weren't updated to reflect the new TAEF version and so have been broken since then. This commit fixes the issue and makes running tests possible again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
As above. Previously, these helper commands to run various test cases would fail with "path not found" errors without running any tests. Now, they work again.
Detailed Description of the Pull Request / Additional comments
The problem occurred because in commit 0905140 (PR #1164), we updated the version of the Taef.Redist.Wlk NuGet package for the TAEF test harness and framework. However, the helper commands hard-code the path to the TAEF executable, which because of NuGet's design includes the TAEF NuGet package version. The commands weren't updated to reflect the new TAEF version and so have been broken since then.
PR Checklist