Skip to content

Add a keybinding for ClosePane#2012

Merged
carlos-zamora merged 1 commit intomasterfrom
dev/migrie/f/993-but-on-master-this-time
Jul 19, 2019
Merged

Add a keybinding for ClosePane#2012
carlos-zamora merged 1 commit intomasterfrom
dev/migrie/f/993-but-on-master-this-time

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Jul 17, 2019

Summary of the Pull Request

Closes #993
When the last pane in a tab is closed, the tab will close.
Bound to Ctrl+Shift+W by default.

References

See #1417 for discussion on the default keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor ClosePane.

PR Checklist

@zadjii-msft
Add a keybinding for ClosePane
27e8d00 
  Closes #993
  When the last pane in a tab is closed, the tab will close.
  Bound to Ctrl+Shift+W by default. See #1417 for discussion on the default
  keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor of
  ClosePane.
@zadjii-msft zadjii-msft requested review from DHowett-MSFT, carlos-zamora and miniksa and removed request for miniksa July 17, 2019 19:06
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jul 17, 2019
DHowett-MSFT
DHowett-MSFT approved these changes Jul 17, 2019
View reviewed changes
src/cascadia/TerminalApp/Tab.cpp
// - <none>
// Return Value:
// - <none>
void Tab::ClosePane()
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: CloseActivePane or CloseFocusedPane

@zadjii-msft zadjii-msft mentioned this pull request Jul 17, 2019
Merged
4 tasks
@carlos-zamora
Copy link
Member

carlos-zamora commented Jul 18, 2019

So, CloseTab still exists, but we're removing the default keybinding for it?

If somebody adds a keybinding for CloseTab, does it still operate as expected and close all the panes, recursively, within the tab? (I trust that it does but I want to double check) I'm guessing when you click the "X" button on the tab header, it does exactly that.

@carlos-zamora carlos-zamora merged commit 5074335 into master Jul 19, 2019
@carlos-zamora carlos-zamora deleted the dev/migrie/f/993-but-on-master-this-time branch July 19, 2019 00:23
@DHowett-MSFT DHowett-MSFT mentioned this pull request Jul 19, 2019
Closed
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
@zadjii-msft @mcpiroman
Add a keybinding for ClosePane (microsoft#2012)
3d29b63 
Closes microsoft#993
  When the last pane in a tab is closed, the tab will close.
  Bound to Ctrl+Shift+W by default. See microsoft#1417 for discussion on the default
  keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor of
  ClosePane.
@ghost
Copy link

ghost commented Aug 3, 2019

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa Awaiting requested review from miniksa

+1 more reviewer

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a shortcut for Close Pane

3 participants

@zadjii-msft @carlos-zamora @DHowett-MSFT