Remove TerminalAzBridge, use AzureConnection directly#19528
Merged
Conversation
We no longer need the intermediate process or ConPTY.
microsoft-github-policy-service
bot
added
Issue-Task
DHowett
added a commit
that referenced
this pull request
Jan 21, 2026
We used to run the cloud shell connector in an intermediate process because our VT implementation lived mostly in conhost. James fixed that up over the intervening years, and since #17510 landed Terminal is exposed to 100% of application-originated VT. That means we no longer need this workaround, its build steps, or anything else about it. Closes #4661 (cherry picked from commit 4b946c0) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgkCt5k Service-Version: 1.24
|
Reviewed |
Member
Author
|
@ferrisx gosh it's a good thing, or we wouldn't have shipped it three months ago! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to run the cloud shell connector in an intermediate process
because our VT implementation lived mostly in conhost. James fixed that
up over the intervening years, and since #17510 landed Terminal is
exposed to 100% of application-originated VT. That means we no longer
need this workaround, its build steps, or anything else about it.
Closes #4661