Conversation
DHowett-MSFT
approved these changes
Jul 11, 2019
Contributor
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Do we need to slap a /utf-8 in sources as well? ;)
DHowett-MSFT
approved these changes
Jul 11, 2019
zadjii-msft
approved these changes
Jul 11, 2019
This was referenced Jul 11, 2019
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
* Set utf-8 for the entire project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
There were a few issues when we first opened the project related to building in other locales because we weren't using UTF-8.
References
#458
#549
I will close those because this supersedes them.
PR Checklist
Detailed Description of the Pull Request / Additional comments
I set the /utf-8 flag globally in the pre props file per the commentary in #458. I also converted the one complaining file
UnicodeLiterals.hppto UTF-8 without a BOM to get it to stop complaining.I have a personal vendetta against BOMs so I'm wholesale rejecting the idea of #549. Microsoft was wrong to BOM. If I had a time machine, I would go egg the person on the .NET team at Microsoft who decided to BOM everything a long time ago and keep going back in time to egg them repeatedly until I felt satisfaction for the pain they've caused me in my life because Microsoft UTF-8 stuff is BOM'd.
Validation Steps Performed