Skip to content

Set utf-8 for the entire project#1929

Merged
miniksa merged 2 commits intomasterfrom
dev/miniksa/utf8
Jul 11, 2019
Merged

Set utf-8 for the entire project#1929
miniksa merged 2 commits intomasterfrom
dev/miniksa/utf8

Conversation

@miniksa
Copy link
Member

@miniksa miniksa commented Jul 11, 2019

Summary of the Pull Request

There were a few issues when we first opened the project related to building in other locales because we weren't using UTF-8.

References

#458
#549
I will close those because this supersedes them.

PR Checklist

  • Closes assorted build issues for people who are fortunate enough to live in places that aren't 'MURICA.
  • CLA not signed but I work at Microsoft so I've already signed away my life.
  • Tests should still pass. I'll let the CI tell me.
  • Doesn't require docs.
  • Hi, it's me. It's my project. You all live in my world.

Detailed Description of the Pull Request / Additional comments

I set the /utf-8 flag globally in the pre props file per the commentary in #458. I also converted the one complaining file UnicodeLiterals.hpp to UTF-8 without a BOM to get it to stop complaining.

I have a personal vendetta against BOMs so I'm wholesale rejecting the idea of #549. Microsoft was wrong to BOM. If I had a time machine, I would go egg the person on the .NET team at Microsoft who decided to BOM everything a long time ago and keep going back in time to egg them repeatedly until I felt satisfaction for the pain they've caused me in my life because Microsoft UTF-8 stuff is BOM'd.

Validation Steps Performed

  • I built it and it's fine.
  • The CI will build it and it will hopefully be fine.
  • I built it in Windows with true Razzle and it's fine.

@miniksa miniksa self-assigned this Jul 11, 2019
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to slap a /utf-8 in sources as well? ;)

@miniksa miniksa merged commit 29522c4 into master Jul 11, 2019
@miniksa miniksa deleted the dev/miniksa/utf8 branch July 11, 2019 20:13
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
* Set utf-8 for the entire project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants