Command: realize resource-key names when they are requested, not at load#19165
Merged
Command: realize resource-key names when they are requested, not at load#19165
Conversation
DHowett
force-pushed
the
dev/duhowett/command-name-resource-or-string
branch
from
a1267a7 to
996b06c
Compare
DHowett
force-pushed
the
dev/duhowett/command-name-resource-or-string
branch
from
996b06c to
e867912
Compare
lhecker
approved these changes
Jul 24, 2025
DHowett
added a commit
that referenced
this pull request
Jul 28, 2025
The bulk of this work is changing `Command::Name` (and its descendants like `GenerateName`) to support looking up names in English and in the local language. When matching a "palette item" with a "subtitle" (a new field introduced to store the English command name when the current language is not English), the weight of the subtitle is used only if it is greater than the weight of the name. This ensures that we do not penalize or over-promote results that contain similar Latin letters in both fields. Refs #19130, #19131, #19132, #19165 Closes #7039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, when a Command's name is
{"key": "ResourceName"}we resolve the resource immediately at load time. That prevents us from looking it up later in another language if we need to.This pull request introduces an intermediate representation for command names which is be resolved during
Command::Name.Refs #7039